Feature/404 447 prevent output with no bisac #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith BISAC or BIC code
This was
linked to
issues
Feb 22, 2024
….rs and onix3_jstor.js, rewrote tests for when no subjects are present
…s, onix3_jstor.rs to only allow BISAC codes
ja573
approved these changes
Feb 26, 2024
brendan-oconnell
deleted the
feature/404-447-prevent-output-with-no-bisac
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses 447 and 404, where the Export API will output in JSTOR and Google Books ONIX format even if record doesn't contain required subject code(s):
Export API will now throw an error for Google Books or JSTOR ONIX formats if an export is attempted from a record without the required codes.